Skip to content

HCK-18460: comment out separate statements of deactivated views and check constraints #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 1 commit into from
Nov 5, 2026
Merged

HCK-18460: comment out separate statements of deactivated views and check constraints #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 36 additions & 22 deletions forward_engineering/ddlProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,14 +504,17 @@ module.exports = (baseProvider, options, app) => {

const table = prepareName(tableName, dbData.databaseName);

return assignTemplates(templates.alterTable, {
tableName: table,
tableOptions: '',
alterStatement: assignTemplates(templates.addCheckConstraint, {
constraintName: checkConstraint.name ? `CONSTRAINT ${prepareName(checkConstraint.name)} ` : '',
expression: checkConstraint.expression,
return commentIfDeactivated(
assignTemplates(templates.alterTable, {
tableName: table,
tableOptions: '',
alterStatement: assignTemplates(templates.addCheckConstraint, {
constraintName: checkConstraint.name ? `CONSTRAINT ${prepareName(checkConstraint.name)} ` : '',
expression: checkConstraint.expression,
}),
}),
});
{ isActivated: checkConstraint.isActivated !== false },
);
},

/**
Expand All @@ -523,13 +526,16 @@ module.exports = (baseProvider, options, app) => {
dropCheckConstraint(tableName, checkConstraint, dbData) {
const table = prepareName(tableName, dbData.databaseName);

return assignTemplates(templates.alterTable, {
tableName: table,
tableOptions: '',
alterStatement: assignTemplates(templates.dropCheckConstraint, {
name: wrap(checkConstraint.name, '"', '"'),
return commentIfDeactivated(
assignTemplates(templates.alterTable, {
tableName: table,
tableOptions: '',
alterStatement: assignTemplates(templates.dropCheckConstraint, {
name: wrap(checkConstraint.name, '"', '"'),
}),
}),
});
{ isActivated: checkConstraint.isActivated !== false },
);
},

/**
Expand Down Expand Up @@ -920,7 +926,7 @@ module.exports = (baseProvider, options, app) => {
* @param {ViewData} viewData
* @return {AlterViewData}
*/
hydrateAlterView({ name, newEntityData, oldEntityData, viewData }) {
hydrateAlterView({ name, newEntityData, oldEntityData, viewData, jsonSchema }) {
const newData = this.hydrateView({
viewData: {},
entityData: newEntityData,
Expand Down Expand Up @@ -951,6 +957,7 @@ module.exports = (baseProvider, options, app) => {
selectStatement: options.selectStatement || newEntityData[0]?.selectStatement,
recursive: options.recursive || newEntityData[0]?.recursive,
options,
isActivated: jsonSchema?.isActivated !== false,
...oldViewData,
...newViewData,
};
Expand Down Expand Up @@ -1266,17 +1273,24 @@ module.exports = (baseProvider, options, app) => {
})
: '';

const isActivated = alterData.isActivated !== false;

if (isEmptyDiffOptions) {
return [renameView, commentScript].filter(Boolean).join('\n\n');
return commentIfDeactivated([renameView, commentScript].filter(Boolean).join('\n\n'), {
isActivated,
});
}

return [
this.dropView({ name: alterData.oldName || alterData.name, dbData }),
this.createView(alterData, dbData, true),
commentScript,
]
.filter(Boolean)
.join('\n\n');
return commentIfDeactivated(
[
this.dropView({ name: alterData.oldName || alterData.name, dbData }),
this.createView(alterData, dbData, isActivated),
commentScript,
]
.filter(Boolean)
.join('\n\n'),
{ isActivated },
);
},

commentStatement(statement) {
Expand Down