Repository navigation
HCK-18434: comment out separate comment statements of deactivated columns and tables - #87
Merged
Merged
Conversation
…umns and tables Co-authored-by: Cursor <cursoragent@cursor.com>
|
chulanovskyi-bs
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Content
HCK-18434: separate comment statements of deactivated columns and tables were not commented out.
Technical details
hydrateAlterTableaddsisActivatedfromjsonSchema.role.isActivated, andalterTablewraps its statements (rename, options,COMMENT ON TABLE) withcommentIfDeactivated.hydrateAlterColumncombines the column flag with the newisParentActivatedparam, so column comments of a deactivated table are commented too.isParentActivatedis sent by Studio, see hackolade/studio branchfix/HCK-18434(same branch name, needed together for CI). With an older Studio the param is missing and the behavior stays as before.Made with Cursor