Repository navigation
Sort reverse-engineered foreign keys by name - #156
Merged
Merged
Conversation
The foreign key query has no ORDER BY, so BigQuery returns rows in a different order from run to run, and the relationships came out in a different order too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
chulanovskyi-bs
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Reverse-engineering now returns foreign keys sorted by name, so their order is the same on every run.
Before, the order followed the rows of the foreign key query, which has no
ORDER BY. BigQuery doesn't keep row order stable, so the Studio BigQuery feature test sometimes failed withsimpleFKandfk$1swapped (TeamCity build 326579).Technical details
reverseForeignKeys: the list of constraint names is sorted. Columns inside each key were already sorted byordinal_position.expectedRE.json(same branch name, so TeamCity builds them together). Merged alone, either one makes the Studio test fail.