Reordered filter order in statusList - #8758
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: weekday 10am - 6pm |
Tomomi-K1
left a comment
There was a problem hiding this comment.
@palak-hellowrld nice job 😄
- merging into correct branch
- changes confirmed on my local env
- order of unfiltered project has changed according to the issue requirement.
|
Availability: Today until 5pm |
cchrizzle
left a comment
There was a problem hiding this comment.
Hi @palak-hellowrld,
Happy Friday! Looks good to me:
- You correctly reordered the items in
statusList - Your screenshots show the changes in effect
- You have correct branching and naming
Approved and great job, have a great Friday and weekend!
computarisis
left a comment
There was a problem hiding this comment.
Hi @palak-hellowrld! I've ran your branch locally and I can confirm that the presented order is now Active-On Hold-Completed, as intended. Good job!
yielderdev
left a comment
There was a problem hiding this comment.
Hi @palak-hellowrld ! In review:
- The pull request done with the correct branch
- There is a linked issue: #8490
- Changes implemented with correct syntax and according to issue request
- Visuals for the changes before and after implementation clearly displayed.
- Changes working on relevant pages and not breaking anything in local env on desktop and responsive design mode
Nice Job! The changes are applicable, don't break anything, and are clean + consistent.
Approved.
Fixes #8490
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied