Skip to content

Reordered filter order in statusList - #8758

Open
palak-hellowrld wants to merge 1 commit into
hackforla:gh-pagesfrom
palak-hellowrld:update-filter-order-8490
Open

Reordered filter order in statusList#8758
palak-hellowrld wants to merge 1 commit into
hackforla:gh-pagesfrom
palak-hellowrld:update-filter-order-8490

Conversation

@palak-hellowrld

Copy link
Copy Markdown
Member

Fixes #8490

What changes did you make?

  • Reordered statusList from "["Active","Completed","On Hold"]" to "["Active","On Hold","Completed"]"

Why did you make the changes (we will use this info to test)?

  • To make the unfiltered display of all projects from Active to On Hold to Completed so that people can ask about or easily see projects that might be reactivated.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Screenshot 2026-08-27 161835 Screenshot 2026-08-27 161906
Visuals after changes are applied Screenshot 2026-08-27 162119 Screenshot 2026-08-27 162137

@github-actions

Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b palak-hellowrld-update-filter-order-8490 gh-pages
git pull https://github.com/palak-hellowrld/website.git update-filter-order-8490

@github-actions github-actions Bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.5pt Can be done in 3 hours or less HLC: C Homepage Launch Countdown Could Have labels Aug 27, 2026
@Tomomi-K1
Tomomi-K1 self-requested a review August 27, 2026 23:52
@Tomomi-K1

Copy link
Copy Markdown
Member

Availability: weekday 10am - 6pm
Review will be done by 8/27/2026 5pm

@Tomomi-K1 Tomomi-K1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palak-hellowrld nice job 😄

  • merging into correct branch
  • changes confirmed on my local env
  • order of unfiltered project has changed according to the issue requirement.

@cchrizzle
cchrizzle self-requested a review August 28, 2026 18:48
@cchrizzle

Copy link
Copy Markdown
Member

Availability: Today until 5pm
ETA: 1pm today

@cchrizzle cchrizzle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @palak-hellowrld,

Happy Friday! Looks good to me:

  • You correctly reordered the items in statusList
  • Your screenshots show the changes in effect
  • You have correct branching and naming

Approved and great job, have a great Friday and weekend!

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Aug 28, 2026
@computarisis
computarisis self-requested a review August 29, 2026 02:14

@computarisis computarisis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @palak-hellowrld! I've ran your branch locally and I can confirm that the presented order is now Active-On Hold-Completed, as intended. Good job!

@yielderdev
yielderdev self-requested a review August 31, 2026 01:44

@yielderdev yielderdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @palak-hellowrld ! In review:

  • The pull request done with the correct branch
  • There is a linked issue: #8490
  • Changes implemented with correct syntax and according to issue request
  • Visuals for the changes before and after implementation clearly displayed.
  • Changes working on relevant pages and not breaking anything in local env on desktop and responsive design mode

Nice Job! The changes are applicable, don't break anything, and are clean + consistent.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue HLC: C Homepage Launch Countdown Could Have P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Status: PRs ✅ waiting for merge team

Development

Successfully merging this pull request may close these issues.

Reorder the Unfiltered Display of all Projects

5 participants