test: Add unit tests for grantpermission router (Vitest/ESM) - #2203
Open
trillium wants to merge 2 commits into
Open
test: Add unit tests for grantpermission router (Vitest/ESM)#2203trillium wants to merge 2 commits into
trillium wants to merge 2 commits into
Conversation
- Use beforeAll + vi.resetModules() + dynamic imports so the router's transitive deps (googleapis, node-fetch, fs) load through the mock registry rather than the real modules - Replace mockReturnValue on OAuth2 constructor with mockImplementation per Vitest v4 class-support requirements - Fix fetch assertions for checkPublicMembership and check2FA (those helpers call fetch with 1 arg, not 2) - Document existing router bugs: check2FA never parses JSON so twoFAenabled always returns true; grantPermission reject path returns 500, not 400
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2091
Adds unit tests for all three routes in
backend/routers/grantpermission.router.js.Changes from jng34's original PR (#2091):
beforeAll+vi.resetModules()+ dynamic imports so the router's transitive dependencies (googleapis,node-fetch,fs) are intercepted through the mock registry rather than the real modulesOAuth2.mockReturnValue→OAuth2.mockImplementation(Vitest v4 forbidsmockReturnValueon constructor calls)fetchassertions forcheckPublicMembershipandcheck2FAhelpers (they callfetchwith 1 arg, not 2)check2FAnever parses the response JSON sotwoFAenabledalways returnstrue;grantPermissionreject path returns 500, not 400Result: 23/23 tests pass in ~300ms