Add first and last name fields to signup form - #175
Open
marccsaada wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130
Overview
Added "Prénom" and "Nom" fields to the signup form, wired into the existing
update/clientErrorsvalidation pattern. Also extendedSignupInput/validateSignupto validate the new fields, and updatedactions.tsso the server action validates and passesfirstName/lastNamethrough the same sharedinputobject (previously it read them separately without validation).Testing
Manual testing in the browser at
/signup:firstName/lastNamecorrectly to theuserstableUnit testing:
validation.test.tsto cover the new required fieldsnpm run test,npx tsc --noEmit, andnpm run lint, all passScreenshots / Screencasts
Checklist
Notes
None.