Skip to content

Add first and last name fields to signup form - #175

Open
marccsaada wants to merge 1 commit into
developfrom
feature/130-first-last-name-signup-form
Open

Add first and last name fields to signup form#175
marccsaada wants to merge 1 commit into
developfrom
feature/130-first-last-name-signup-form

Conversation

@marccsaada

Copy link
Copy Markdown
Contributor

Closes #130

Overview

Added "Prénom" and "Nom" fields to the signup form, wired into the existing update/clientErrors validation pattern. Also extended SignupInput/validateSignup to validate the new fields, and updated actions.ts so the server action validates and passes firstName/lastName through the same shared input object (previously it read them separately without validation).

Testing

Manual testing in the browser at /signup:

  • Verified Prénom/Nom fields display above email, styled consistently with existing inputs
  • Verified validation errors show under each field when left empty
  • Verified a full signup saves firstName/lastName correctly to the users table
  • Verified layout on mobile and desktop

Unit testing:

  • Updated validation.test.ts to cover the new required fields
  • Ran npm run test, npx tsc --noEmit, and npm run lint , all pass

Screenshots / Screencasts

image

Checklist

  • Code is neat, readable, and works
  • Code is commented where appropriate and well-documented
  • Commit messages follow our guidelines
  • Issue number is linked
  • Branch is linked
  • Reviewers are assigned (one of your tech leads)

Notes

None.

@marccsaada marccsaada added this to the sprint-4 milestone Aug 23, 2026
@marccsaada marccsaada self-assigned this Aug 23, 2026
@marccsaada marccsaada added back-end back-end related issue front-end front-end related issue labels Aug 23, 2026
@vercel

vercel Bot commented Aug 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
canopee-project Ready Ready Preview Aug 23, 2026 5:51pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

back-end back-end related issue front-end front-end related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant