Repository navigation
docs: audit next.17 release notes and upgrade guidance - #839
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Breaking-change coverage correction: #824's tmux/zellij warning was already at the page tail, but outside the next.17 section. This moves it into that section and puts the retained-v4 stop procedure before switching. No additional undocumented breaking change was identified; #767 and #781's behavior-change guidance were already present and were checked against candidate Audit head @codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Updated to Final local docs prepare/check/typecheck/build, command/source-link audit, privacy and 1,330-commit Gitleaks pass. HTTP smoke: 97 docs, 82 SVGs, 217 local links/anchors; server stopped. Site tests remain 2 passed / 25 assertions on unchanged site inputs. The cancelled old-head CI run had a queued replacement; no duplicate rerun was requested. Waiting for this head's hosted/bot checks before Ready for lead. The candidate freeze remains in force. @codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Breaking-change coverage correction: #824's tmux/zellij warning existed at the page tail but was outside the next.17 section. It is now in that section, with the retained-v4 stop procedure before switching and a fresh stopped-state backup for rollback. The env breaking entry was already correct. #781's table is now complete, including frozen fallbacks/runtime-bound compounds, Ready for lead: All 71 candidate commits are mapped in the description to entry present / added / not user-visible, with PR and candidate-pinned source links. Eight Markdown files only; runtime, tests, workflows, pin, snapshots and diagrams match candidate Persistent Claude Opus second-family review is CLEAN at this exact head. Codex code and automatic security reviews found no issues; all conversation comments were read. Hosted CI 43585059152 passed the docs site (prepare/check/typecheck/site tests/build/HTTP smoke), secret scan, all planned Linux unit shards 4–8 and test fan-in. Typecheck/privacy/quality ran on shard 8. Focus had no selected tests. Mac, compiler/native runtime, process-lifetime, models, images and Docker execution were out of scope; the Docker fan-in success does not imply Docker scenarios ran. Local validation: Bun 1.4.4 frozen dependencies; docs prepare/check/typecheck/build; site tests 2 passed/25 assertions on unchanged site inputs; all 50 named commands and 19 option contracts checked against the regenerated CLI reference with no drift; source links/anchors; privacy; full-history Gitleaks (1,330 commits, no findings). Production-mode HTTP smoke passed 97 docs, 82 SVGs and 217 local links/anchors. All task servers are stopped. No live install, migration, daemon/DNS/trust change, Docker or VM acceptance is claimed. The candidate freeze remains in force. This is ready for your post-publication docs/site-repin batch; you own the decision on whether the moved breaking-change notice should land before the cut. No merge or publication was performed. Separate code follow-up: |
|
Lead decision on the pre-cut question: the tmux breaking-change warning is already on the release-notes page (at its tail), and the commit itself is marked breaking ( 🤖 Generated with Claude Code |
The next.17 section omitted the tmux breaking-change warning that already existed at the page tail. Move it into the release section and put its v4 stop procedure before the v5 trial. The env breaking entry was already correct; keep its scoped single-key/terminal/stdin migration guidance.
Audit all 71 commits from
v5.0.0-next.16(b21c3b1898) through candidate5002cf87bb50686b17ceae8a4c835f524ee1b3a5against merged code and PR text. Add missing upgrade-assistant, activity, observe/plan/version, interactive exec, recovery, background-command and host/secret-custody notes. Preserve the complete native env-file behavior table and mark the four new JSON contracts shape may change before 5.0.0, with the planned HACK-2238 envelope migration.Correct stale native interactive-exec/network/metadata/Ctrl-C claims and the short upgrade assistant wording. Credit the publisher-shutdown fix to #719, already in next.16; keep next.17 lifecycle-command retirement separate. Retake a private stopped-state backup after v4 stops zellij, keeping the first copy too. Keep next.16 warnings scoped to that bundle. Keep original-key backups before older Doctor migrations and distinguish file rollback from runtime/data recovery.
Only eight Markdown files change. Runtime, tests, workflows, generated CLI reference, diagrams, immutable snapshots and the site pin are unchanged. No diagram changed, so a new visual would add nothing. The site re-pin remains a separate release follow-up.
Merge timing: respect the lead's candidate freeze; intended for the batch immediately after next.17 publication and the site re-pin. The moved tmux breaking-change notice is called out for the lead's pre-cut decision. This PR does not merge or publish anything.
Validation at
d95cfc554fabc4a0d70e3ba6caeb6746f63a198c:Candidate commit coverage
entry presentmeans the behavior already had an entry within the next.17 section (some now have fuller detail).addedmeans missing behavior or migration guidance was added there; #824 moves the existing warning into that section.not user-visiblemeans no shipped CLI/runtime change: documentation, test/CI/repository housekeeping or the internal desktop preview. Source links pin the candidate, rather than a moving branch.