Skip to content

test(lifecycle): keep shared-helper rollback fixture ports distinct #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roodboi merged 3 commits into from
Nov 14, 2026
Merged

test(lifecycle): keep shared-helper rollback fixture ports distinct #829

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e54433
test(lifecycle): keep shared-helper rollback fixture ports distinct
roodboi Nov 14, 2026
0fbd685
test(lifecycle): identify unexpected shared-helper claim kind
roodboi Nov 14, 2026
4627ed4
chore: merge next into shared-helper fixture fix
roodboi Nov 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tests/project-shared-helpers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,9 @@ async function readHelperClaim(
async function ownedIdentity(root: string, helper: ProjectSharedHelperConfig) {
const claim = await readHelperClaim(root, helper);
if (claim?.ownership !== "owned") {
throw new Error("expected an owned claim");
throw new Error(
`expected an owned claim; observed ${claim?.ownership ?? "missing"}`
);
}
return { pid: claim.pid, birth: claim.birth };
}
Expand Down Expand Up @@ -404,19 +406,22 @@ test(
async () => {
const root = await scratch();
const first = helperConfig({ port: freePort() });
// Bind the first helper before selecting the second port: released port-0
// probes can return the same port, letting the foreign listener satisfy first.

// Branch A already holds the first helper from an earlier successful up.
await startProjectSharedHelpers({
...context(root),
helpers: [first],
composeProject: BRANCH_A,
});
const owned = await ownedIdentity(root, first);

// Keep the first port bound while selecting the second: two closed bind
// probes can return the same port, making the foreign fixture look adoptable.
const second = helperConfig({
port: freePort(),
name: "second-bridge",
});
expect(second.port).not.toBe(first.port);
// The second port is held by a different helper kind (foreign).
const other = await startForeign({
root,
Expand Down
Loading