Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa53b943b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
# Conflicts: # apps/desktop/README.md # apps/desktop/app/src/setup_controller.rs # apps/desktop/app/src/view.rs # apps/desktop/core/src/lib.rs
Always-on and login-service lines showed design request ids such as "needs R12b". They now say what is missing in plain words; a test guards the unknown line. The two affected screenshots are re-rendered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76b12d1a31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
…find the live socket Setup Run and the daemon card executed daemon commands with the app's own runner, skipping the checked report's pinned CLI, its allowlisted environment and the effect-time install refusal. They now go through setup's checked context only, and refuse without a checked report. The daemon observer also never read the socket in a normal launch, so a version mismatch was never shown; it now finds the socket from the CLI's own socket_path, like the project snapshot, and uses the same pinned CLI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codex couldn't complete this request. Try again later. |
# Conflicts: # apps/desktop/app/src/screenshots.rs # apps/desktop/app/src/view.rs
# Conflicts: # apps/desktop/README.md
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
# Conflicts: # apps/desktop/core/src/source.rs # apps/desktop/core/tests/dump_state.rs
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
# Conflicts: # apps/desktop/core/src/setup_io.rs
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Ready for lead: d838bb1 The base is What changed since the last note
The three Doctor security limits listed on #806 apply here too. What ran
Not verified or not waited for:
|
|
Codex couldn't complete this request. Try again later. |
Adds the DESIGN §5–6 desktop slice: a daemon card with observed status and explicit Start, Restart and Install login-service actions, plus read-only always-on state and fixtures. Accepts the current producer’s API-running report even when tracked-PID
runningis false, retaining service metadata. A missing status is Unknown, an omittedservice.installedis not false, and only explicit R8 metadata identifies a stale unit. Version mismatch comes from socket/v1/status.Setup Run, recovery and card actions share one gate through command exit, fresh daemon status and an ordered project snapshot. Failure retains observed evidence and an error; timeout stays Unknown until a read. Project actions also disable during machine recovery. There are no startup mutations, unit edits, direct daemon signals, administrator prompts or terminal adapters.
Always-on consumes proposed R12 fields for on/off, manual-stop pause, failure count/limit/services, global pause and login progress. All switches remain disabled with needs-R12a/R12b guidance: no live command capability is established. No autostart commands, policy, persistence or retries are added. Missing CLI disables actions. Stacked on setup PR #819 (
feat/desktop-app-setup), normally merging its candidate90b4355. Setup Run routes through the same typed daemon adapter; terminal code is reused unchanged. Setup terminal launches and daemon actions mutually gate; action results queue setup refresh if an older read is in flight. Core fixes throughd39223e5are merged normally; matching-daemon-only project reads, ordered refreshes, stale Unknown rows/services, recovery fixtures and unknown engine footer are preserved.Validation: workspace Rust 1.98.1; jobs=2; 119 unit and 23 integration tests (including temporary HOME/HACK_HOME, fake CLI/PATH and injected Unix sockets), rustfmt, default and screenshots Clippy with warnings denied, both builds, and bounded offscreen fixture captures in light/dark with visual inspection (60 before integration, representative captures repeated after setup integration). No network, real daemon/registry/login service, Docker or sudo in tests. Screenshots use placeholder fixture data only.
R8/R12 implementation and native macOS qualification remain separate work. Optional desktop feature (
feat), no release packaging changes. Second-family exact-head review is pending; this is an implementation checkpoint, not a readiness claim.Update (Nov 15)
nexte47681e). Daemon card actions, setup actions and project actions share one gate:machine_action_busy()(daemon card or setup busy) andaction_busy()(also any project action in flight).