feat(desktop): add names-only environment tab by roodboi · Pull Request #818 · hack-dance/hack

roodboi · 2026-11-14T03:44:00Z

Adds the names-only Env tab: read on open, project change and Check again, missing required names first, locked/unknown key readability, and explicit empty versus unreadable states. Uses hack env list --json --path <root> without a value flag; exit 1 still accepts a bare report. Typed models discard values/materialized fields and raw diagnostics. Generations drop stale selections; marker/discovery guards refuse missing or ancestor-shadowed roots. Canonical selected-scope absence differs from project-wide absence; empty legacy scope arrays show global.

Visible copy explains that key readability can be unknown and that Set indicates storage, not confirmed readability. The locked state shows hack doctor beside Copy command. The available app/core tabs and fixtures contain no internal request/ticket IDs outside source comments; the core always-on tooltip and README are aligned. No native Env, key handling, badge styling or upstream CLI-shape changes.

Based on next; core warmups, ordered snapshots, log-tail invalidation and recovery gates are preserved. Local Linux at 08db90a: Rust 1.98.1, own target, jobs 2; fmt, 77 unit + 6 integration tests, both Clippy modes with warnings denied, both builds and privacy pass. Eight affected Env light/dark screenshots were rendered and inspected at the copy-fix head bb70d35; the subsequent frozen-next merge changes no UI/fixtures and retains those receipts. Loading/error renders are retained unchanged. Fake CLI/temp HOME/HACK_HOME/autostart disabled; no real env command, owner registry/daemon, Docker, sudo or GUI window.

Normal merge of frozen next 8e7242d is pushed at 08db90a. README preserves Env docs and incoming process-retirement test guidance; runner tests match next/843. No app/Env read logic changed. Root and desktop scripts/test.sh are absent, so pinned own-target Cargo checks were used; no unmerged 846 wrapper was imported. Exact-head Codex and SAME persistent Claude r5 are clean; review-status CLEAR. Both hosted desktop jobs and successful replacement CI selected shards/fan-in pass. Final Ready for lead at frozen 08db90a supersedes all earlier holds; superseded cancellation excluded. Absolutely no more pushes. No PR merge during next.17 freeze; lead only after publication. Lead's macOS build/renders/state pass covers the previous 609d5cc head; new copy has fresh Linux offscreen evidence and the frozen merge head has hosted Linux/macOS desktop success; runtime limitations remain. Separately tracked macOS spawn flakes are not changed here. No full-CI-green, merge or release claim.

Limits: real env CLI rejects native roots, so native Env is Unreadable pending CLI support; fake native tests prove backend selection/parser behavior only. macOS keychain prompting remains unverified. Reads are bounded but not deduplicated; stale results are discarded. Marker pre/post checks are not an atomic filesystem fence. No merge or watcher by this unit.

Freeze branch-update order: #846 → #818 → #808. Env MERGE PUSHED is complete, so Logs can be NEXT. Preserve shared tab/fixture/screenshot/source hooks. No PR merges during freeze; lead only after publication. No new shape adoption or scope.

…CK-2214) New Cargo workspace under apps/desktop, separate from runtime-core: - core: lenient models for hack --json and hackd payloads, a CLI runner that kills the whole process group on timeout, a read-only hackd socket client, project state derivation, list/detail view models and fixtures for every designed state. 33 hermetic unit tests. - app: the gpui-kit window (sidebar, header with Start/Stop/Restart/Open, services table, log tail, status bar, light and dark), --fixtures mode and offscreen PNG rendering behind the screenshots feature. - A separate, non-required Linux CI job for the desktop workspace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…finished one-shot services as completed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…eout, drop stale log tails Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…abel Docker state as Docker Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…arden chunk parsing, never count unknown as stopped Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…, gate native actions and logs, clear recovered failures Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…er peer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>