Repository navigation
fix(native): explain preflight refusals by service and field - #795
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Pushed test-only follow-up Also gave the retained-file invalid-deadline test the same 30-second setup budget as adjacent cases. It passed locally in 6.6 seconds with all 11 assertions unchanged; the prior 5-second harness limit was too short. Product deadlines are unchanged. Persistent review CLEAN at this head. Focused environment tests, changed-test lint, all-feature Clippy and privacy passed locally. Full TS and new-head hosted CI remain pending; no Ready claim. |
|
@codex review Please review current head |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Pushed the lead's required fixes at
Persistent reviewer delta: CLEAN at this exact SHA. Local evidence: 45 TS tests pass, 21 Mac cases skipped; root typecheck, check/privacy, changed-file lint and docs prepare/check pass; focused Rust precedence/service regression and all-feature runtime build pass. A real Rust Full Rust, full TS and hosted current-head verification remain pending. Deferred coverage/location/deduplication items are tracked on HACK-2192, comment Integration with @codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Integrated the explicitly confirmed next batch The shared 1 MiB structured failure budget, authored service/field rendering, first-error service on graph_budget, and report v2 are preserved. The startup error budget also rises from 256 KiB to 1 MiB; explicit startup-log validation is unchanged. Lead-owned real-project census remains separate. @codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Merged confirmed Current-head Linux checks: 52 incoming regression tests pass, 430 assertions, plus typecheck and check/privacy. Earlier Rust/model results apply only to unchanged inputs; full TypeScript and exact-head hosted qualification remain pending. Correction to the earlier triage: the No Ready or real-Mac claim. Lead owns acceptance and merge. @codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
The older frozen full TypeScript run at A new frozen full-suite run has started at |
|
Merged current Current-head local evidence: 87 focused lifecycle/host-process/readiness/hint tests pass (538 assertions), docs prepare/check pass. Typecheck/lint are finishing. Rust and model inputs are unchanged; prior results remain identified by their tested revisions. Fresh hosted and bot qualification is pending. The broad No Ready claim at this head and no PR merge performed. @codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
The frozen local full TypeScript run passed at 85859ed: 11,073 passed, 404 skipped, 0 failed, 105,115 assertions across 761 files (pinned Bun 1.4.4, umask 022, prepared compiler; CLI test task executed, DB test task cached). The checkout remained clean and unchanged throughout the run. This is prior-head Linux evidence, not a run of current |
|
Reviewer handoff update: the lead reports the Hack Dance Claude account unavailable. I attempted the requested replacement, Muse second-family review: pending, lead The previous static CLEAN at |
|
Prepared integration: Normally merged frozen The same persistent second-family reviewer returned CLEAN at this exact head, including the resolutions and integration fix. Local checks at this source:
Two local setup failures were corrected without changing source or assertions: the guest invocation initially lacked the configured C-compiler shim; four project-share tests initially rejected my group-writable temporary ancestor. With the shim and private temporary-directory permissions, the guest gate and full Rust suites passed. Hosted CI and bot review for this new head are pending. Linux checks do not qualify skipped Mac fixtures; no additional macOS dispatch was requested. After #794 lands, this PR still needs the resulting normal integration, resolution review and final-head checks before |
|
@codex review Please review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Ready for lead: 6cc53d6 Takeover note: this unit moved to a new owner session after the previous one ran out of capacity. Nothing was pushed in this session; the head above is the previous owner's integration of frozen Merge with Second merge after #794: yes, it will be needed. A scratch merge of #794's head 3cda82b into this head conflicts in 4 files, one hunk each:
The merge also needs two non-conflicting test fixes:
The scratch result typechecks, and 327 focused tests pass: native-preflight-cli, upgrade-check, native-runtime-client, native-preflight* and doctor*. 8 doctor adopted-project tests fail, but they fail the same way on plain Review:
Hosted checks at this head: 27 pass, 1 skipped, 2 failed:
This PR does not touch that file or the download code. The failure is not one of the named flakes (HACK-2235, HACK-2243), so I did not rerun it. Please rerun the failed job, or tell me to. Not verified:
|
Resolutions: - native-preflight: `ready` needs no blockers, no consent, a completed review and ready runtime setup; the report keeps `runtime_setup` and `consent_needed`; exit still follows blockers plus consent. - upgrade-check: the informational summary counts blockers and consent items and says setup and review were not checked. - dependency_cache.rs: keep finding collection and add next's anonymous-volume refusal with the same precedence (only when nothing earlier refused). - service.rs: compile_services takes the mutable volume map that next's anonymous volumes need. - tests: keep both imports; probe stub gains consentNeeded; the no-effects assertion allows next's read-only `runtime setup` inspect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Ready for lead: 177cc9f This head is a normal merge of Merge resolutions:
Admission is unchanged. Every refusal still names its service and field, and values are never shown. Review:
Hosted, exact-head run:
Ran locally (Linux, pinned toolchains):
Not verified: the macOS jobs above, macOS-only authored-startup fixtures, real-VM scenarios, and the 18-project preflight census. These are the lead's Mac batch. |
Native preflight hid the offending service and field behind generic graph refusals, and counted missing shared-source consent as a configuration blocker. This adds fixed, value-free reasons and remedies from the existing runtime admission checks.
consent_needed; text and JSON keep all discovered blockers regardless of consentAdmission predicates and first-error precedence are preserved. No native feature is enabled. Malformed detail batches fall back to a closed refusal; repeated findings are deduplicated. All structured runtime failures have a 1 MiB bound, including authored
upplanning; startup errors rise from 256 KiB to 1 MiB while startup-log schema bounds and the explicit log-decoding gate remain unchanged. Authored startup preserves validated service/field findings, and per-service resource-budget refusals identify the service. Structurally invalid input may still stop review early.Tracks HACK-2192, diagnostics-only first unit. Release intent:
fix. JSON consumers must accept report version 2 and usereadyfor the verdict.The frozen
nextintegration preserves both configuration-refusal and interactive-session diagnostics, plus the extracted file-only preflight collector.hack upgrade checknow counts missing consent separately and requires both zero blockers and zero consent items before describing a project as native-ready. Its finding remains informational, so Compose is unaffected.Validation includes the real CLI consent projection, focused refusal/transport/startup tests, default and all-feature Rust gates, native guest compilation, compiled CLI/compiler acceptance, typecheck, lint, privacy and docs checks. Exact-head outcomes and hosted/bot status are recorded in the integration comment. Linux results do not qualify deferred macOS fixtures; no additional Mac jobs are requested by this integration.
This PR follows #794. Final Ready waits for the lead's #794 merge confirmation, any required normal merge and resolution review, and the resulting head's checks. The next.17 freeze and lead merge authority remain in force.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.