Fix type mismatch in standard_deviation() tests - #58
Merged
Conversation
[why] The return value of StandardDeviation<T>::mean() in this case is the default, double. Therefore we should compare it to a double literal, not to TestType.
Member
|
Hmm, I must admit I do not understand what assigning 'all' means. I thought you assigned me specifically, that is why I merged. 
How can all be assigned? |
Member
Author
Ah, sorry, I got into the wrong section. I meant to request a review from everyone, not assign everyone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return value of
StandardDeviation<T>::mean()in this test case forstandard_deviation()is of the default type, double. Therefore we should compare it to a double literal, not toTestType.