Fix warning about possible integer truncation - #54
Merged
Conversation
Member
Author
|
We also need to update our Visual Studio build helper: Will address that in a separate PR. |
alt-graph
requested review from
Finii,
Seim2k17,
ohensler,
soerengrunewald and
zykure
August 31, 2026 12:30
alt-graph
marked this pull request as ready for review
August 31, 2026 12:30
Finii
approved these changes
Aug 31, 2026
[why]
gcc warns about data loss in an implicit integer conversion:
SmallVector.cc:1318:31: warning: conversion from ‘std::vector<unsigned int>::size_type’
{aka ‘long unsigned int’} to ‘unsigned int’ may change value [-Wconversion]
1318 | (vec.size() == 0) ? 0 : (dist(gen) % vec.size());
[how]
Use an explicit static_cast to get to the correct integer size.
alt-graph
force-pushed
the
cleanup/integer_size
branch
from
August 31, 2026 13:56
0e5d518 to
a84a77b
Compare
Member
Author
|
Thanks again, @Finii! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[why]
gcc warns about data loss in an implicit integer conversion:
[how]
Use an explicit
static_castto get to the correct integer size.