Allow custom advanceTimers implementation and update tick to microtask based approach - #231
Open
OiNutter wants to merge 3 commits into
Open
Allow custom advanceTimers implementation and update tick to microtask based approach#231OiNutter wants to merge 3 commits into
OiNutter wants to merge 3 commits into
Conversation
- Reworks userEvent to use a common user event session across all commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #215.
Details
As discussed in original issue allow providing custom
advanceTimersimplementation tovirtual.start()which can then be provided to the internaluserEventusage. To allow this theuserEventusages have been updated to use a shared session created viauserEvent.setup. This will also ensure thedefaultUserEventOptionsare actually applied as expected as v14 of@testing-library/user-eventdoesn't support passing the options as a second parameter.Additionally updated the
tickhelper to usePromise.resolverather than a setTimeout approach to reduce impact of using fake timers.Verified existing tests pass and added new tests to ensure custom
advanceTimersis calledCheckList