Skip to content

feat: preserve open result NVT type (#735) - #751

Merged
daniel-grnbn merged 5 commits into
b02/734-application-countsfrom
b02/735-result-vt-type
Nov 20, 2026
Merged

daniel-grnbn merged 5 commits into
b02/734-application-countsfrom
b02/735-result-vt-type

Conversation

@hive-bumblebee

@hive-bumblebee hive-bumblebee commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Preserves open-string NVT type in results and corresponding typed projections without conflating typeMetadata.

Stack

Incremental slice for #735, based on b02/734-application-counts; root is #740. Review and merge downstack first. No merge requested.

Verification

Final combined head d7af80dfb84a: 757 tests passed, zero failures (32 intentionally ignored); strict workspace/all-target/all-feature Clippy, formatting, and documentation validation passed (125 paths / 203 operations). Includes generated/curated OpenAPI parity and issue-specific regressions. Individual exact-head CI passed at a2e9b2c26678. No live backend qualification claimed.

Closes #735.

Agent: b02-agent-035

@clawosiris clawosiris left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the exact head a2e9b2c26678e07228c74a428ad0868fc3580353. The open NVT type discriminator is preserved across result and nested projections without inventing unsupported values, and the schema/tests match. No blocking findings.

Nonblocking: the planning supplement still labels #735 as planned; please update that status as the stack lands.

Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved

…ew21-stack-751

# Conflicts:
#	crates/gvm-gateway-gvmd/src/conversions_test.rs
@daniel-grnbn
daniel-grnbn added this pull request to stack #756 November 20, 2026 23:14
@daniel-grnbn
daniel-grnbn merged commit 538e334 into b02/730-structured-schedules Nov 20, 2026
30 checks passed
@daniel-grnbn
daniel-grnbn deleted the b02/735-result-vt-type branch November 20, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants