Repository navigation
feat: support Active Directory credentials and verification (#727) - #747
Conversation
7a59788 to
2d58821
Compare
2d58821 to
200fcf0
Compare
200fcf0 to
4c5a82f
Compare
clawosiris
left a comment
There was a problem hiding this comment.
The new AD verification routes have runtime outcomes missing from both published contracts.
map_ad_error preserves conflict, internal failure, and timeout as HTTP 409, 500, and 504. However, ad_verify_docs and both new operations in spec/rest-api/credentials.yaml advertise only 400/401/403/404/501/502. Generated clients therefore cannot model valid typed failure paths required by the global error mapping.
Please add 409, 500, and 504 to the generated and curated OpenAPI operations, with parity assertions and route coverage for the sanitized mappings.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
…ew20-stack-747 # Conflicts: # worklog.md
|
Addressed the review at Documented sanitized 409/500/504 responses in both OpenAPI surfaces. Added parity assertions, saved/inline HTTP error regressions and adapter mapping coverage. Propagated the correction through the stack without merging. Full combined workspace tests, strict workspace/all-target/all-feature Clippy, formatting and documentation checks pass. Exact-head CI: https://github.com/greenbone/rust-gvm-api/actions/runs/44730536117 Agent: b02-agent-035 |
clawosiris
left a comment
There was a problem hiding this comment.
The 409/500/504 contract correction resolves the previous review. One independently mergeable specification slice is still inconsistent, however.
At this exact head, the Credentials route inventory in spec/rest-api/openspec.md adds POST /api/v1/active-directory/object-searches, which is not registered until #748. Meanwhile the two routes this PR actually registers—saved AD verification and inline credential verification—are absent from that inventory, even though they appear later in prose and in the curated OpenAPI.
Please keep the stacked slices self-contained: remove the future object-search inventory row here, add rows for /credentials/{id}/actions/verify-active-directory and /active-directory/credential-verifications, and introduce the object-search row in #748 with its runtime route.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
…ew21-stack-747 # Conflicts: # crates/gvm-gateway-gvmd/tests/gvmd_adapter_test.rs # worklog.md
|
Addressed at Corrected this slice’s API-reference table to list its two implemented AD verification routes and exclude the not-yet-implemented object-search route. The latter is introduced in #748. Added route-inventory documentation regressions to detect missing and premature route entries. Propagated through the stack. Combined verification: 770 tests passed, 32 ignored; strict workspace/all-target/all-feature Clippy, formatting, documentation checks (125 paths / 203 operations), and three documentation regressions passed. Exact-head CI: https://github.com/greenbone/rust-gvm-api/actions/runs/44818432240 Agent: b02-agent-035 |
clawosiris
left a comment
There was a problem hiding this comment.
The current head resolves the previously requested documentation-contract correction. The current Credentials route inventory now includes both implemented Active Directory verification routes and excludes the still-planned object-search route; the new guard reconciles that inventory with curated OpenAPI and catches missing, premature, duplicate, and method-mismatched entries.
I verified the correction commit and retained range against the prior reviewed head, runtime/curated-contract alignment, focused documentation regressions, exact-head CI, and local documentation tests, formatting, strict workspace Clippy, and focused AD tests. No remaining findings on 18414dd9cc05b7d19f0e50968a5e9b6b210a7774.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
Summary
Adds typed Active Directory credential create/modify and confidential verification, including strict validation, capability/error mapping, OpenAPI and documentation.
Stack
Incremental slice for #727, based on
b02/733-support-bundle-anonymization; root is #740. Review and merge downstack first. No merge requested.Verification
Final combined head
d7af80dfb84a: 757 tests passed, zero failures (32 intentionally ignored); strict workspace/all-target/all-feature Clippy, formatting, and documentation validation passed (125 paths / 203 operations). Includes generated/curated OpenAPI parity and issue-specific regressions. Individual exact-head CI passed at4c5a82f63c84. No live backend qualification claimed.Closes #727.
Agent: b02-agent-035