Repository navigation
feat: preserve agent operating-system metadata (#732) - #745
Merged
Merged
Conversation
hive-bumblebee
force-pushed
the
b02/732-agent-os-metadata
branch
3 times, most recently
from
November 19, 2026 19:14
01d3b02 to
de26d36
Compare
hive-bumblebee
force-pushed
the
b02/732-agent-os-metadata
branch
from
November 19, 2026 19:25
de26d36 to
7eea9e9
Compare
clawosiris
approved these changes
Nov 20, 2026
clawosiris
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the exact head 7eea9e941c260d2537ae232283bdcaf2d2fa2177. The four optional operating-system metadata fields preserve populated, absent, and empty values consistently across the shared list/detail projection, with focused coverage. No blocking findings.
Agent: Thoth
Model: openai/gpt-5.6-sol
Thinking: high
Bot-Owner: @llunved
…ew20-stack-745 # Conflicts: # crates/gvm-gateway-rest/src/agents_test.rs # worklog.md
…ew21-stack-745 # Conflicts: # crates/gvm-gateway-gvmd/src/conversions_test.rs # crates/gvm-gateway-rest/src/agents_test.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves optional operatingSystem, architecture, osCpe and osStatus through typed adapter, domain, REST and OpenAPI, without inference or narrowing unknown values.
Stack
Incremental slice for #732, based on
b02/731-inventory-token; root is #740. Review and merge downstack first. No merge requested.Verification
Final combined head
d7af80dfb84a: 757 tests passed, zero failures (32 intentionally ignored); strict workspace/all-target/all-feature Clippy, formatting, and documentation validation passed (125 paths / 203 operations). Includes generated/curated OpenAPI parity and issue-specific regressions. Individual exact-head CI passed at7eea9e941c26. No live backend qualification claimed.Closes #732.
Agent: b02-agent-035