Repository navigation
Add: Add target source support. - #1406
Merged
Merged
Conversation
greenbonebot
enabled auto-merge (rebase)
November 19, 2026 14:53
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1406 +/- ##
=======================================
Coverage 98.52% 98.53%
=======================================
Files 107 107
Lines 7072 7091 +19
Branches 1306 1310 +4
=======================================
+ Hits 6968 6987 +19
Misses 74 74
Partials 30 30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the optional target-source changes.
No open issues 🎉
What changed in this PR
Adds optional target-source support to GMP Next target creation and modification, enabling discovered computer objects to be matched against existing targets.
Changes:
- Introduces
TargetSourcewithmanualandactive_directoryvalues and exposes the optionalsourceparameter. - Adds tests for source serialization, omission, validation, and mixed-case input.
- Documents the new enum in the GMP Next API reference.
| File | Description |
|---|---|
tests/protocols/gmpnext/entities/targets/test_modify_target.py |
Adds source-handling tests for target modification. |
tests/protocols/gmpnext/entities/targets/test_create_target.py |
Adds source-handling tests for target creation. |
gvm/protocols/gmp/requests/next/_targets.py |
Defines TargetSource and adds source handling to XML requests. |
gvm/protocols/gmp/requests/next/__init__.py |
Exports TargetSource. |
gvm/protocols/gmp/_gmpnext.py |
Exposes and forwards the optional source parameter. |
docs/api/gmpnext.md |
Adds API documentation for TargetSource. |
Review effort: Balanced
timopollmeier
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Support optional source on target creation and modification
Why
Required for matching discovered computer objects against existing targets.
References
GEA-2214
Checklist