Repository navigation
Support active directory searches - #1405
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
greenbonebot
enabled auto-merge (rebase)
November 18, 2026 10:38
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1405 +/- ##
==========================================
+ Coverage 98.51% 98.52% +0.01%
==========================================
Files 106 107 +1
Lines 6993 7072 +79
Branches 1288 1306 +18
==========================================
+ Hits 6889 6968 +79
Misses 74 74
Partials 30 30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Invalid TLS strings lose InvalidArgument metadata in three credential methods, breaking callers that rely on it for field-specific error handling.
1 open issue
What changed in this PR
Adds Active Directory object searches to GMPNext and TLS-mode enum support to existing credential operations, extending the client’s Active Directory integration.
Changes:
- Adds configurable searches using saved credentials, with filtering, result limits, and optional target/task details.
- Supports TLS-mode enums when creating, modifying, and verifying credentials; rejects boolean port values.
- Adds API documentation and tests for serialization, validation, and enum conversion.
| File | Description |
|---|---|
tests/protocols/gmpnext/enums/test_active_directory_tls_mode.py |
Tests TLS-mode enum conversion. |
tests/protocols/gmpnext/enums/test_active_directory_search_scope.py |
Tests search-scope enum conversion. |
tests/protocols/gmpnext/enums/test_active_directory_object_type.py |
Tests object-type enum conversion. |
tests/protocols/gmpnext/entities/test_active_directory.py |
Registers the directory-search test case. |
tests/protocols/gmpnext/entities/credentials/test_verify_active_directory_credential.py |
Tests TLS enums and boolean port rejection during verification. |
tests/protocols/gmpnext/entities/credentials/test_modify_active_directory_credential.py |
Tests TLS enums and boolean port rejection during modification. |
tests/protocols/gmpnext/entities/credentials/test_create_active_directory_credential.py |
Tests TLS enums and boolean port rejection during creation. |
tests/protocols/gmpnext/entities/active_directory/test_get_active_directory_objects.py |
Tests search request serialization and validation. |
tests/protocols/gmpnext/entities/active_directory/__init__.py |
Exports the search test mixin. |
gvm/protocols/gmp/requests/next/_credentials.py |
Adds TLS-mode enum support and stricter port validation. |
gvm/protocols/gmp/requests/next/_active_directory.py |
Defines search enums, validation, and XML request construction. |
gvm/protocols/gmp/requests/next/__init__.py |
Exports the new request builder and enums. |
gvm/protocols/gmp/_gmpnext.py |
Exposes directory searches and updated credential signatures. |
docs/api/gmpnext.md |
Documents the new Active Directory enums. |
Review effort: Balanced
timopollmeier
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Added support for searching Active Directory objects.
Support TLS mode enums when creating, modifying or verifying AD credentials .
Why
Required for Active Directory integration.
References
GEA-2105
Checklist