You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Uint::overflowing_shl/overflowing_shr returned false-negative overflow
flags. overflowing_shl missed bits shifted above BITS but within the top
limb (non-limb-aligned widths such as U160), and limbs wholly discarded by
shifts >= 64; overflowing_shr missed wholly discarded low limbs. Shifted
values were correct; only the flag was wrong.
The wrong flag propagates: checked_shl/checked_shr return Some instead
of None, strict_* fail to panic, and saturating_* return a wrapped
value instead of saturating. The incorrect checked_shl result causes to_base_be (and string formatting) to loop forever on no-alloc builds for
non-limb-aligned widths — a denial of service if formatting is reachable
from untrusted input.
Separately, wrapping_shl/wrapping_shr on 64/128/256-bit types truncated
the shift amount modulo 2^32, so shifts >= 2^32 returned an incorrectly
wrapped value instead of zero; on 32-bit targets the generic path also
truncated 64-bit shift amounts.
Callers using checked or saturating shift semantics on untrusted shift
amounts may compute incorrect results.
Not affected: graph-node calls none of the affected checked/overflowing/saturating/wrapping/strict shift functions or byte(), and BigInt shifts use num-bigint with u8 shift amounts. Triage: #6788
Activity
dimitrovmaksim commentedon Nov 16, 2026
Not affected: graph-node calls none of the affected
checked/overflowing/saturating/wrapping/strictshift functions orbyte(), andBigIntshifts use num-bigint withu8shift amounts. Triage: #6788