Repository navigation
fix(auth): invalidate previous API keys on Kafka updates - #1228
Open
juanmardefago wants to merge 1 commit into
Open
juanmardefago wants to merge 1 commit into
juanmardefago wants to merge 1 commit into
Conversation
Kafka updates replaced the ID-to-key mapping but left the previous secret in the authorization cache, allowing rotated keys to continue authorizing queries. Remove the previous secret and insert its replacement within the same cache update. Apply this to every key update, including bootstrap events, while preserving same-secret policy updates and unrelated keys. Add regression tests for authorization after rotation, repeated events, bootstrap and ordinary updates, deletion, and same-secret policy changes. Document the remaining source-ordering limitation for stale events. Validation: all 52 tests pass; the rotation regression fails against the original handler. Formatting, strict Clippy, and diff checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kafka updates replaced the ID-to-key mapping but left the previous secret in the authorization cache, allowing rotated keys to continue authorizing queries.
Remove the previous secret and insert its replacement within the same cache update. Apply this to every key update, including bootstrap events, while preserving same-secret policy updates and unrelated keys.
Add regression tests for authorization after rotation, repeated events, bootstrap and ordinary updates, deletion, and same-secret policy changes. Document the remaining source-ordering limitation for stale events.
Validation: all 52 tests pass; the rotation regression fails against the original handler. Formatting, strict Clippy, and diff checks pass.