Skip to content

fix(auth): invalidate previous API keys on Kafka updates - #1228

Open
juanmardefago wants to merge 1 commit into
mainfrom
fix/kafka-api-key-rotation
Open

juanmardefago wants to merge 1 commit into
mainfrom
fix/kafka-api-key-rotation

Conversation

@juanmardefago

Copy link
Copy Markdown

Kafka updates replaced the ID-to-key mapping but left the previous secret in the authorization cache, allowing rotated keys to continue authorizing queries.

Remove the previous secret and insert its replacement within the same cache update. Apply this to every key update, including bootstrap events, while preserving same-secret policy updates and unrelated keys.

Add regression tests for authorization after rotation, repeated events, bootstrap and ordinary updates, deletion, and same-secret policy changes. Document the remaining source-ordering limitation for stale events.

Validation: all 52 tests pass; the rotation regression fails against the original handler. Formatting, strict Clippy, and diff checks pass.

Kafka updates replaced the ID-to-key mapping but left the previous secret
in the authorization cache, allowing rotated keys to continue authorizing
queries.

Remove the previous secret and insert its replacement within the same
cache update. Apply this to every key update, including bootstrap events,
while preserving same-secret policy updates and unrelated keys.

Add regression tests for authorization after rotation, repeated events,
bootstrap and ordinary updates, deletion, and same-secret policy changes.
Document the remaining source-ordering limitation for stale events.

Validation: all 52 tests pass; the rotation regression fails against the
original handler. Formatting, strict Clippy, and diff checks pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant