Repository navigation
fix(performance): update both feedback buffers - #1221
Merged
Merged
Conversation
chriswessels
marked this pull request as ready for review
October 29, 2026 13:48
tmigone
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actor::handle_msgsdrains its batch while updating the first snapshot, so the second snapshot never receives query feedback. Readers falling back to it while the first buffer is write-locked can see stale performance and indexing progress.Apply the complete batch to both buffers before clearing it. The regression forces reads through each buffer after successful and failed feedback and checks latency, success rate, and monotonic observed progress.
Validation (on this independent branch):
cargo +nightly-2026-06-11 fmt --all -- --checkcargo +1.95.0 clippy --all-targets --all-features -- -Dwarnings --force-warn deprecated --force-warn dead-codecargo +1.95.0 test