Repository navigation
Conversation
… labels - subgraph-manifest: point SpecVersion 1.3.0 to the Subgraph Composition guide and fix the other outdated /developing/... links and anchors on the page (graphprotocol#944) - graphql-api: note the default (100) and maximum (1000) values of `first` (graphprotocol#977) - using-subgraph-studio: state that version labels must be unique (graphprotocol#961)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Subgraph manifest page (#944):
subgraphs/developing/creating/subgraph-manifest.mdx/subgraphs/guides/subgraph-composition/instead of the 404/cookbook/subgraph-composition-three-sources./developing/creating/...paths, which have no redirect innginx.conf. They now use/subgraphs/developing/creating/.... The anchors are unchanged and match the existing headings./developing/creating-a-subgraph/#grafting-onto-existing-subgraphs) redirected to a page that doesn't have that anchor. It now points to/subgraphs/developing/creating/advanced/#grafting-onto-existing-subgraphs.#time-travel-queriesnow reads#time-travel-queries-example, which matches the current heading ("Time-travel Queries Example") ingraphql-api.mdx.GraphQL API page (#977):
subgraphs/querying/graphql-api.mdxfirstis omitted, a query returns at most 100 entities. The maximum is 1000, the Graph Node default set byGRAPH_GRAPHQL_MAX_FIRST. Asking for more returns an error.master@3b2f05d4b5213f7ddcfcd5a8005d291be1b38fd1):graph/src/schema/api.rs:first.default_value = Some(s::Value::Int(100.into()))graph/src/env/graphql.rs:#[envconfig(from = "GRAPH_GRAPHQL_MAX_FIRST", default = "1000")]graphql/src/store/query.rs: returnsRangeArgumentsErrorwhenfirstis greater thanmax_firstdocs/environment-variables.md: "If not provided,firstdefaults to 100. The default value forGRAPH_GRAPHQL_MAX_FIRSTis 1000."Subgraph Studio page (#961):
subgraphs/developing/deploying-publishing/using-subgraph-studio.mdxVersion label already exists, which is the error quoted in Clarify if version labels for subgraph deployments have to be unique #961.Checks
Run locally after
pnpm install --frozen-lockfile. The lockfile is unchanged.pnpm lint: passedpnpm prettier:check: passedpnpm typecheck: passedOnly English source pages were edited.