Skip to content

Fix indexing.rst doc-example failures - #1850

Closed
vaimdevs wants to merge 1 commit into
fix/site-wide-org-dataset-errorfrom
fix/indexing-rst-examples
Closed

Fix indexing.rst doc-example failures#1850
vaimdevs wants to merge 1 commit into
fix/site-wide-org-dataset-errorfrom
fix/indexing-rst-examples

Conversation

@vaimdevs

@vaimdevs vaimdevs commented Aug 4, 2026

Copy link
Copy Markdown
Contributor 
##Fix
* Fix indexing.rst doc-example failure — define new_edges_df before use in the invalidation example (was raising NameError).

@vaimdev
docs(gfql): fix indexing.rst doc-example failures
4e7654b 
Mark the intro teaser block as doc-test:skip (pseudocode, g undefined
at that point) and define new_edges_df in the invalidation example so
it actually runs instead of raising NameError.
@lmeyerov
lmeyerov changed the base branch from fix/site-wide-org-dataset-error to master August 18, 2026 18:46
@lmeyerov
lmeyerov changed the base branch from master to fix/site-wide-org-dataset-error August 18, 2026 18:47
@lmeyerov lmeyerov mentioned this pull request Aug 18, 2026
Merged
lmeyerov added a commit that referenced this pull request Aug 18, 2026
@lmeyerov
Merge pull request #1933 from graphistry/docs/indexing-rst-new-edges-df
3c512c9 
docs(gfql): fix indexing.rst doc-example NameError (cherry-pick of #1850)
@lmeyerov

lmeyerov commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Your fix landed on master via #1933 (cherry-pick of 4e7654bce, authorship preserved) so it didn't have to wait behind #1721's review — this PR will show as resolved/empty once #1721 merges master forward. Thanks for catching the NameError; verified the amount column exists in the page's own edges_df and that assign returning a new frame is exactly the invalidation lesson the example teaches.

@vaimdev
vaimdev force-pushed the fix/site-wide-org-dataset-error branch 2 times, most recently from 510625a to f24fb45 Compare September 2, 2026 09:06
@lmeyerov

lmeyerov commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Closing as already landed: the one-line docs/source/gfql/indexing.rst fix this PR carries is on master via #2017 (merged 2026-10-02), and the page was reworked around it since (Cypher-first quick start, adjacency subsection). Relative to this PR's own base branch (fix/site-wide-org-dataset-error) nothing else is pending — that branch will pick the line up when it next merges master. Thanks for catching the doc-example failures; please reopen if a residual difference remains on your side.

@lmeyerov lmeyerov closed this Oct 3, 2026
@lmeyerov
lmeyerov deleted the fix/indexing-rst-examples branch October 17, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vaimdevs @lmeyerov @vaimdev