Preserve SortedDict invariants when update input raises - #255
Open
vitalivo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #254, which was accidentally closed and its source fork deleted. The implementation is unchanged; the original discussion and reviews remain linked there.
Calling
update()on an emptySortedDictwith a malformed pair or an iterator that raises can leave keys in the underlying dictionary but not in its sorted index. After catching the original exception,len(d)disagrees with iteration and_check()fails.Materialize iterable input before taking the empty-dictionary fast path, as the nonempty path already does. The direct-dict optimization remains. Tests cover malformed pairs with and without a key function, a failing generator, and nonempty controls; three cases fail on the base revision.
Validation: all 372 tests, doctests, and stress tests pass on Python 3.12. Ruff passes for the changed library file. Repository-wide Ruff reports five existing B905 diagnostics in untouched
sortedlist.py; formatting reports an existing adjacent string literal atsorteddict.py:194. No new lint or formatting issues were introduced.