Skip to content

feat: pass per-request timeout, retry and abort opts through to request executor - #333

Merged
teofanis merged 1 commit into
mainfrom
feat/add-timeout-and-retry-opts-to-commercetools-api-request
Aug 28, 2026
Merged

teofanis merged 1 commit into
mainfrom
feat/add-timeout-and-retry-opts-to-commercetools-api-request

Conversation

@teofanis

Copy link
Copy Markdown
Contributor

getRequestOptions() was not returning timeoutMs, aggregateTimeoutMs, retry and abortController, so per-request overrides used the instance-level defaults.

@teofanis teofanis self-assigned this Aug 27, 2026
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.32%. Comparing base (b8f2977) to head (f9fe4b0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files          58       58           
  Lines        1475     1481    +6     
  Branches      156      158    +2     
=======================================
+ Hits         1465     1471    +6     
  Misses          2        2           
  Partials        8        8           
Files with missing lines Coverage Δ
src/lib/api/CommercetoolsApi.ts 99.14% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@teofanis
teofanis requested a review from jimmythomson August 27, 2026 12:58
@teofanis
teofanis merged commit e6bc295 into main Aug 28, 2026
5 checks passed
@teofanis
teofanis deleted the feat/add-timeout-and-retry-opts-to-commercetools-api-request branch August 28, 2026 12:54
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 6.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants