Skip to content

mapAsync on destroyed device #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sagudev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mapAsync on destroyed device #4713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions src/webgpu/api/validation/buffer/mapping.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,37 @@ g.test('mapAsync,invalidBuffer')
);
});

g.test('mapAsync,destroyedDevice')
.desc('Test that mapAsync is an error when called on a destroyed device.')
.params(u =>
u.combine('bufferState', ['valid', 'invalid'] as const).combine('awaitLost', [true, false])
)
.fn(async t => {
const { awaitLost, bufferState } = t.params;
const buffer =
bufferState === 'valid' ? t.createMappableBuffer(GPUMapMode.READ, 4) : vtu.getErrorBuffer(t);
t.expectDeviceLost('destroyed');

await t.testMapAsyncCall(
bufferState === 'valid'
? 'success'
: { validationError: true, earlyRejection: false, rejectName: 'OperationError' },
buffer,
GPUMapMode.READ
);
buffer.unmap();
t.device.destroy();
if (awaitLost) {
const lostInfo = await t.device.lost;
t.expect(lostInfo.reason === 'destroyed');
}
await t.testMapAsyncCall(
{ validationError: false, earlyRejection: false, rejectName: 'AbortError' },
buffer,
GPUMapMode.READ
);
});

g.test('mapAsync,state,destroyed')
.desc('Test that mapAsync is an error when called on a destroyed buffer.')
.paramsSubcasesOnly(u => u.combine('mapMode', kMapModeOptions))
Expand Down
Loading