Announce top-three leaderboard changes#512
Merged
Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Most submissions now arrive through the API while people still gather in Discord and read rankings on gpumode.com. Discord-only submission hooks therefore miss the leaderboard moments worth celebrating.
Behavior
Validation
ruff check src/kernelbot/top_three.py src/kernelbot/cogs/top_three_cog.py tests/test_top_three.py src/kernelbot/main.pyPYTHONPATH=/Users/mark/Dev/kernelbot-top-three-pr/src pytest -q tests/test_top_three.py(10 passed)python -m compileall -q src/kernelbotAn actual staging Discord connection could not be performed because
DISCORD_DEBUG_TOKENis absent from the local environment, macOS Keychain, and the connected Infisical dev/staging/prod environments. The production token was intentionally not reused for staging.