Repository navigation
fix(watch,wait): register update handlers before connecting - #289
Open
ApexAiOfficial wants to merge 1 commit into
Open
ApexAiOfficial wants to merge 1 commit into
ApexAiOfficial wants to merge 1 commit into
Conversation
watch and wait added their handlers to the update dispatcher inside the run callback, i.e. after the client had connected and could already be dispatching updates. tg.UpdateDispatcher keeps handlers in a plain map, so registering concurrently with dispatch is a data race (and can panic with a concurrent map write). runParams gains a register hook that connectWith calls on the fresh dispatcher before the client is created. The message stream is registered there and stays inert until armed with the resolved peer filter, which keeps the existing behavior: events before the filter is known were never delivered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
watch and wait added their handlers to the update dispatcher inside the run
callback, i.e. after the client had connected and could already be
dispatching updates. tg.UpdateDispatcher keeps handlers in a plain map, so
registering concurrently with dispatch is a data race (and can panic with a
concurrent map write).
runParams gains a register hook that connectWith calls on the fresh
dispatcher before the client is created. The message stream is registered
there and stays inert until armed with the resolved peer filter, which keeps
the existing behavior: events before the filter is known were never delivered.
🤖 Generated with Claude Code