Repository navigation
fix(upload): do not panic on a missing path - #288
Open
ApexAiOfficial wants to merge 1 commit into
Open
ApexAiOfficial wants to merge 1 commit into
ApexAiOfficial wants to merge 1 commit into
Conversation
The filepath.Walk callback evaluated info.IsDir() before checking the walk error. For a path that does not exist Walk passes a nil FileInfo, so `tg upload ./missing.pdf` panicked with a nil pointer dereference after connecting. Check the error first (in a small tested walkFiles helper), and stat the path before connecting so the failure is immediate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filepath.Walk callback evaluated info.IsDir() before checking the walk
error. For a path that does not exist Walk passes a nil FileInfo, so
tg upload ./missing.pdfpanicked with a nil pointer dereference afterconnecting. Check the error first (in a small tested walkFiles helper), and
stat the path before connecting so the failure is immediate.
🤖 Generated with Claude Code