cl loadTypedef: ignore Cursor_TypeAliasTemplateDecl; tool test: TestLLVM_iterator_range - #875
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
+ Coverage 86.65% 86.77% +0.11%
==========================================
Files 22 22
Lines 1829 1830 +1
==========================================
+ Hits 1585 1588 +3
+ Misses 244 242 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Review: template type-alias / using-declaration handling
This PR extends declaration handling to skip C++ template type aliases (Cursor_TypeAliasTemplateDecl), treat using-declarations as no-ops, and thread the enclosing class scope through loadTypedef so class-nested typedefs resolve template type parameters. It also upgrades log.Panicln/log.Println to ctx.panicf/ctx.logf, which is a nice improvement since those attach source position to diagnostics. The new TestLLVM_ADL fixture exercises exactly these paths (ADL.h contains function templates, a using-based adl_detail namespace, and template-dependent type aliases), and the near-empty out.go confirms they are correctly skipped.
Verified: scopeCtx is the first embedded field of classCtx, so the unsafe.Pointer cast in scope() is sound; passing nil scope from the top-level loadDecl call site is safe because lookupType guards with a nil-receiver loop. No correctness-blocking issues. Two minor polish items are noted inline.
No description provided.