cl toTypeEx: ignore unsupported type; tool test: TestLLVM_String - #874
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
==========================================
+ Coverage 86.00% 86.65% +0.65%
==========================================
Files 22 22
Lines 1822 1829 +7
==========================================
+ Hits 1567 1585 +18
+ Misses 255 244 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Review: cl toTypeEx ignore unsupported type; TestLLVM_String
The refactor is clean and well-motivated. Replacing the panic in toTypeEx with log-and-ignore is a sensible robustness improvement for a binding generator that must tolerate unusual headers, and the templateObj→templateClass rename plus the new logtf helper read well. Enabling TestLLVM_String with a committed golden file gives good regression coverage for the ignore path.
One design point is worth confirming before merge (finding below on toTypeEx): the featIgnored signal is only honored by the function and typedef paths. Field/var/union/enum callers use toType, which discards feats, so an unsupported type now flows through as types.Typ[types.Invalid] rather than failing fast. This path partially pre-existed (ignored record/typedef types at type.go:128-129), but this change broadens the set of inputs that reach it. The remaining items are minor cleanups from the rename.
No description provided.