Skip to content

cl toTypeEx: ignore unsupported type; tool test: TestLLVM_String - #874

Merged
xushiwei merged 3 commits into
goplus:mainfrom
xushiwei:q
Sep 29, 2026
Merged

xushiwei merged 3 commits into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.65%. Comparing base (bed9e2c) to head (4fc9d90).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
cl/type.go 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
+ Coverage   86.00%   86.65%   +0.65%     
==========================================
  Files          22       22              
  Lines        1822     1829       +7     
==========================================
+ Hits         1567     1585      +18     
+ Misses        255      244      -11     
Flag Coverage Δ
llgo-tests 86.65% <85.71%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: cl toTypeEx ignore unsupported type; TestLLVM_String

The refactor is clean and well-motivated. Replacing the panic in toTypeEx with log-and-ignore is a sensible robustness improvement for a binding generator that must tolerate unusual headers, and the templateObj→templateClass rename plus the new logtf helper read well. Enabling TestLLVM_String with a committed golden file gives good regression coverage for the ignore path.

One design point is worth confirming before merge (finding below on toTypeEx): the featIgnored signal is only honored by the function and typedef paths. Field/var/union/enum callers use toType, which discards feats, so an unsupported type now flows through as types.Typ[types.Invalid] rather than failing fast. This path partially pre-existed (ignored record/typedef types at type.go:128-129), but this change broadens the set of inputs that reach it. The remaining items are minor cleanups from the rename.

Comment thread cl/type.go
Comment thread cl/ctx.go Outdated
Comment thread cl/ctx.go Outdated
Comment thread cl/type.go Outdated
@xushiwei
xushiwei merged commit e3edcda into goplus:main Sep 29, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant