cl compileFuncOrMethod: skip template method - #871
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
==========================================
+ Coverage 82.09% 85.12% +3.03%
==========================================
Files 22 22
Lines 1798 1802 +4
==========================================
+ Hits 1476 1534 +58
+ Misses 322 268 -54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Review: switch func-object map key from mangling name to USR
The refactor is clean and internally consistent. Every access to the renamed ctx.fns map (addFunc, loadOutsideMethod, vtableMethodName) now keys on funcUSR(...), no references to the removed funcObj.manglingName remain, and the struct comment was updated to fnUSR => func object. Two positive changes worth noting: avoidKeyword is now a pure return-a-string function (no pointer mutation), and moving clang.Mangling into compileFuncOrMethod means mangling is computed once per func instead of twice.
The empty-string guard added only to clang/mangling_withprefix.go (darwin) is correct — the linux variant in clang/mangling_normal.go does not slice [1:], so it cannot panic on an empty name; both now return "" consistently.
Findings below are non-blocking robustness/coverage observations.
No description provided.