Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsUint("4294967296")returns false even though the equivalentuint64value passes. The string branch parses with a 32-bit limit, rejecting valid unsigned values between 2^32 and 2^64−1. The registereduintrule has the same limit.Use a 64-bit unsigned parse in both paths. Added tests through the public helper and map validation for the 32-bit boundary and MaxUint64, plus invalid/overflow controls.
Validation: the two values above MaxUint32 fail before the change in both paths. Full race/coverage tests, build, vet, and golangci-lint (no new issues) pass.