Conversation
3eb7aaa to
8c6b89b
Compare
8c6b89b to
293149c
Compare
293149c to
00469c2
Compare
00469c2 to
37ae58f
Compare
There was a problem hiding this comment.
Android Lint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
37ae58f to
98c117d
Compare
| layer.addLayerToMap() | ||
| // [END maps_android_utils_kml_add_layer] | ||
|
|
||
| // [START maps_android_utils_kml_remove_layer] |
There was a problem hiding this comment.
Same class of issue I flagged on #2426, smaller in scope here. This PR drops 3 devsite region tags from the repo entirely:
| tag | was in |
|---|---|
maps_android_utils_kml_remove_layer |
this file, line 52 |
maps_android_ktx_install_snippet |
snippets/app-ktx/build.gradle.kts:74 |
maps_android_utils_ktx_install_snippet |
snippets/app-utils-ktx/build.gradle.kts:73 |
I verified by diffing every [START ...] tag between feat/snippets-java-app and feat/snippets-kotlin-app, then grepping each missing one across the whole tree to rule out relocation.
The two *_install_snippet tags are the Gradle dependency snippets for the KTX libraries, which are exactly the sort of thing an installation page includes by tag. Worth noting that snippets/app-ktx/build.gradle.kts is detected as a rename to snippets/kotlin-app/build.gradle.kts (R059), so the file survives but the tag inside it does not.
Could you carry these three across to the new module, or confirm they are safe to retire?
Separately, nice work on the androidTest suites here. SnippetDiscoveryTest plus the per-capability tests is a good pattern, and it's a real step up from what the legacy modules had.
There was a problem hiding this comment.
Addressed in commit bc534e92. All 3 dropped devsite region tags have been restored and verified:
maps_android_ktx_install_snippetandmaps_android_utils_ktx_install_snippethave been carried over tosnippets/kotlin-app/build.gradle.kts.maps_android_utils_kml_remove_layerhas been added toUtilsSnippets.kt(removeKmlLayer).- Also forwarded missing
GoogleMapmethods onTrackedMap.ktand eliminated.delegatecalls across snippet tags, and sanitized API key logging inMapActivity.kt.
98c117d to
bc534e9
Compare
bc534e9 to
25476e6
Compare
8aace02 to
65c7503
Compare
65c7503 to
d3c82f0
Compare
…est suites - Create :snippets:kotlin-app with 14 snippet categories, KTX extensions, and documentation region tags - Add Kotlin snippet infrastructure (KotlinSnippetsActivity, MapActivity, SnippetRegistry, TrackedMap) - Add Kotlin capabilities test suite (CatalogCapabilitiesTestSuite, CameraControl, Events, MapInit, Marker) - Add Kotlin visual test suite (BaseVisualTest, VisualTests) - Remove legacy Kotlin snippet modules (snippets/app-ktx, snippets/app-utils-ktx) - Update root settings.gradle.kts
… calls, and sanitize logging
…map state and apply live feedback
d3c82f0 to
5ecabb3
Compare
Summary
Stacked Base
Stacked on #2426 (
feat/snippets-java-app).Reviewers
@kikoso