Conversation
… maps3d-compose-demo
dkhawk
marked this pull request as ready for review
September 22, 2026 17:11
dkhawk
added this pull request to stack #73
September 22, 2026 17:12
LoyalAbbas
reviewed
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR (1 of 2)
maps3d-composeandmaps3d-compose-demoSummary
Applies
spotlessApply(ktlint) code formatting to pre-existing files across themaps3d-composeandmaps3d-compose-demomodules.Both modules configure the Spotless Gradle plugin with
target("**/*.kt")andktlint(), enforcing strict adherence to line-length limits (max-line-length 100), argument wrapping, and newline conventions. Pre-existing unformatted lines onmaincausedspotlessCheckfailures on feature branches; this PR brings all files in these modules into 100% spotless compliance.Also refactors
WhiskeyCompass.ktdrawing logic into dedicated privateDrawScopehelper functions (drawCompassStrip,drawDegreeTick,drawCardinalLabel,drawDegreeLabel) to eliminate deep indentation nesting and maintain clean line lengths.Changes by Module
maps3d-composeGoogleMap3D.kt: Moved trailing inline comment to its own line to keep line length <= 100.CameraUpdate.kt: Wrapped multi-line expression body inFlyAroundOptions.toCameraUpdate().Units.kt: Wrapped conditional expressions and template instantiations inImperialUnitsConverterandMetricUnitsConverter.Utilities.kt: Wrapped long function headers and KDoc comments.maps3d-compose-demoCameraAnimationsActivity.kt: Wrapped suspend extension function declaration and listener callbacks.MapInteractionsActivity.kt: Wrapped camera setup lambda arguments.TiltScale.kt: Formatted canvas drawing parameters and line wraps.WhiskeyCompass.kt: Formatted compass canvas drawing; encapsulated parameters inCompassStripParamsand extracted tick, strip, and label drawing into privateDrawScopehelpers to eliminate deep nesting and manage line lengths cleanly.BaseVisualTest.kt: Formatted method signature forcaptureScreenshot().Maps3DVisualTest.kt: Formatted JSON parsing and assertion failure message wrapping.Verification
./gradlew :maps3d-compose:spotlessCheck :maps3d-compose-demo:spotlessCheck-> BUILD SUCCESSFUL./gradlew :maps3d-compose:lintDebug :maps3d-compose-demo:lintDebug-> BUILD SUCCESSFUL./gradlew :maps3d-compose:compileDebugKotlin :maps3d-compose-demo:compileDebugKotlin-> BUILD SUCCESSFUL