ci(storage): add GCS read microbenchmark runner and Cloud Build config - #18298
Open
shradhakatyal wants to merge 2 commits into
Open
ci(storage): add GCS read microbenchmark runner and Cloud Build config#18298shradhakatyal wants to merge 2 commits into
shradhakatyal wants to merge 2 commits into
Conversation
Add automated Cloud Build CI workflow and test runner script for high-bandwidth GCS DirectPath read microbenchmarks against rapid zonal buckets. - Add benchmarks-cloudbuild.yaml to orchestrate VM lifecycle and private SSH runs. - Add run_benchmark_tests.sh for VM environment setup and pytest execution. - Display formatted performance results table directly in Cloud Build logs.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a Cloud Build pipeline (benchmarks-cloudbuild.yaml) and a runner script (run_benchmark_tests.sh) to automate running GCS DirectPath read microbenchmarks on high-bandwidth GCE VMs. The review feedback highlights several critical improvements: implementing a bash trap to guarantee the VM is stopped on early exit, adding defensive type-validation for loaded JSON data to comply with the repository style guide, fixing potential TypeError and ValueError bugs during benchmark result parsing, and verifying that the runtime patching of conftest.py does not fail silently.
… and type validation - Add EXIT trap to ensure standing VM shutdown on failure. - Check SSH connection success and fail if connection times out. - Add target existence validation when patching conftest.py. - Add defensive type validation (isinstance) for parsed JSON results. - Wrap float conversion for network throughput in try-except.
Author
|
/gcbrun e682ba4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add automated Cloud Build CI workflow and test runner script for high-bandwidth GCS DirectPath read microbenchmarks against rapid zonal buckets.