-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(gapic): add OpenTelemetry T3 client method span wrapping in gapic_v1.method (D) #18274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chalmerlowe
wants to merge
33
commits into
feat/otel-tracing-transport-logic
from
feat/otel-tracing-t3-method-spans
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
6821444
feat(gapic): add OpenTelemetry T3 client method span wrapping
chalmerlowe 32e763b
chore(gapic): remove _is_tracing_supported dummy class variable
chalmerlowe e6cc276
test(gapic): achieve 100% branch and statement coverage for OTel T3 m…
chalmerlowe 99336ec
refactor(gapic): extract _extract_rpc_identity and add method_name to…
chalmerlowe b612dad
refactor(gapic): support custom tracer_provider and cache tracer in _…
chalmerlowe 225a02e
feat(gapic): gate T3 method spans for HTTP transports and streaming RPCs
chalmerlowe 4aded8d
refactor(gapic): use span_context_manager to guarantee single wrapped…
chalmerlowe 9df74e6
test(gapic): update and expand unit tests for T3 method tracing refac…
chalmerlowe 35ca839
refactor(gapic): simplify wrap_method with client_options and method_…
chalmerlowe 685338e
feat(gapic): add explicit trace parameter to wrap_method
chalmerlowe 6c3548d
refactor(gapic): replace trace with is_streaming in wrap_method
chalmerlowe 3878df9
Removes line from docstring
chalmerlowe 05f93d3
Update docstring re: streaming methods.
chalmerlowe d06fdd4
Update comment re: streaming
chalmerlowe 5b787ff
refactor(gapic): refine exception handling for tracer resolution and …
chalmerlowe 8f3a649
refactor(gapic): document graceful bypass of otel errors and remove p…
chalmerlowe 249d62c
test(gapic): add rigorous assertions to negative and fallback tracing…
chalmerlowe 136e4b7
test(gapic): refactor and deduplicate otel unit tests using fixture a…
chalmerlowe 5e8e0ed
feat(gapic): add gcp.client.* attributes to T3 method span
chalmerlowe 6115f83
test(gapic): use reusable constants for expected span attributes in o…
chalmerlowe b81cc31
test(gapic): consolidate async otel tests into test_method_async and …
chalmerlowe cfe5dd0
ci: temporarily exclude sqlalchemy-bigquery from package shards
chalmerlowe a20cac2
refactor(gapic): remove deferred gcp.client.* attributes
chalmerlowe f7dd27f
feat(gapic): update rpc attributes to modern semconv
chalmerlowe 013cce8
feat(gapic): record rpc.response.status_code on method spans
chalmerlowe bd4f845
feat(gapic): extract and record gcp.errors attributes on method spans
chalmerlowe aca7aeb
fix(gapic): resolve _error_info and exception properties in _extract_…
chalmerlowe fe96bb4
fix(gapic): resolve mypy union-attr errors in status code and error a…
chalmerlowe c70fd27
test(gapic): achieve 100% test coverage for status code and error ext…
chalmerlowe e06de69
docs(gapic): document status code extraction locations and harmonize …
chalmerlowe ba70e1b
test(gapic): test uninstrumented exception propagation when span is None
chalmerlowe 35b6483
docs(gapic): document error attribute extraction locations with struc…
chalmerlowe da54ee5
feat(gapic): gate Tier 3 method span creation on gRPC transport kind
chalmerlowe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
The change to
get_package_shardsis only a temp work-around to deal with the fact that sqlalchemy-bigquery was causing failing tests in this PR that are unrelated to the PR changes.This will all be reverted prior to merge once we have a long-term solution in place for sqlalchemy-bigquery.