test(generator): rename test service and proto to MediaService and add GetMediaMetadata method - #14440
Merged
Conversation
whowes
added this pull request to stack #14390
September 18, 2026 23:29
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the showcase service 'ResumableUploadService' to 'MediaService' and introduces a new non-resumable RPC method 'GetMediaMetadata' to it. It updates the parser allowlist, test loaders, and all corresponding auto-generated golden files (including stubs, clients, settings, and samples) to reflect these changes. I have no additional feedback to provide as there are no review comments.
whowes
removed this pull request from stack #14390
September 18, 2026 23:50
whowes
added this pull request to stack #14441
September 18, 2026 23:52
whowes
removed this pull request from stack #14441
September 18, 2026 23:53
whowes
force-pushed
the
whowes/test-media-service
branch
from
September 19, 2026 00:08
8c67083 to
e4b264e
Compare
whowes
added this pull request to stack #14442
September 19, 2026 00:11
whowes
force-pushed
the
whowes/test-media-service
branch
from
September 19, 2026 00:38
e4b264e to
06bfff4
Compare
whowes
force-pushed
the
whowes/test-media-service
branch
2 times, most recently
from
September 19, 2026 01:13
d981097 to
3bcbc5b
Compare
whowes
force-pushed
the
whowes/test-media-service
branch
from
September 21, 2026 15:20
3bcbc5b to
9845c53
Compare
whowes
force-pushed
the
whowes/test-media-service
branch
from
September 21, 2026 17:17
9845c53 to
f32cdbd
Compare
whowes
force-pushed
the
whowes/test-media-service
branch
from
September 21, 2026 17:33
f32cdbd to
43a6545
Compare
blakeli0
reviewed
Sep 22, 2026
| static final ImmutableList<Pattern> RESUMABLE_UPLOAD_ALLOWLIST_PATTERNS = | ||
| ImmutableList.of( | ||
| Pattern.compile("^google\\.showcase\\.v1beta1\\.ResumableUploadService\\.UploadMedia$"), | ||
| Pattern.compile("^google\\.showcase\\.v1beta1\\.MediaService\\.UploadMedia$"), |
Contributor
There was a problem hiding this comment.
nit: Add a comment that this is for unit tests only.
blakeli0
approved these changes
Sep 22, 2026
whowes
force-pushed
the
whowes/test-media-service
branch
from
September 22, 2026 00:33
43a6545 to
6de573b
Compare
whowes
force-pushed
the
whowes/test-media-service
branch
from
September 22, 2026 02:18
6de573b to
f402272
Compare
whowes
marked this pull request as ready for review
September 22, 2026 02:19
Base automatically changed from
whowes/showcase-resumable-upload-it
to
main
September 22, 2026 02:22
…d GetMediaMetadata method
whowes
force-pushed
the
whowes/test-media-service
branch
from
September 22, 2026 02:22
f402272 to
7fc2056
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we'd checked in a copy of
resumable_upload.protofrom showcase to be used in generator unit tests for resumable uploads. This was confusing becauseThis PR changes the test proto to
media.proto, the service toMediaService, and adds aGetMediaMetadatamethod, with the intention to make diffs/testing for future changes more understandable.