Skip to content

test(bigquery): add ITBigQueryTest integration tests for queryArrow - #14403

Merged
jinseopkim0 merged 6 commits into
mainfrom
feat-bigquery-arrow-it
Sep 18, 2026
Merged

jinseopkim0 merged 6 commits into
mainfrom
feat-bigquery-arrow-it

Conversation

@jinseopkim0

Copy link
Copy Markdown
Contributor

This PR adds integration tests verifying the queryArrow client API against the live BigQuery service.

It tests single-page and multi-page Arrow stream consumption, validating row counts and VectorSchemaRoot iteration over live queries.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds integration tests to verify query results in Arrow format. Specifically, it introduces testQueryResultsFormatArrow and testQueryResultsFormatArrowMultiPage in ITBigQueryTest.java to validate both single-page and multi-page query results using ArrowQueryResult and VectorSchemaRoot. I have no feedback to provide as there are no review comments.

@jinseopkim0
jinseopkim0 added this pull request to stack #14406 September 16, 2026 17:04
@jinseopkim0
jinseopkim0 marked this pull request as ready for review September 16, 2026 17:04
@jinseopkim0
jinseopkim0 requested review from a team as code owners September 16, 2026 17:04
@jinseopkim0
jinseopkim0 requested a review from lqiu96 September 16, 2026 17:04
@jinseopkim0
jinseopkim0 requested a review from lqiu96 September 17, 2026 01:30

@lqiu96 lqiu96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a small comment

Base automatically changed from feat-bigquery-arrow-client to main September 18, 2026 16:17
@jinseopkim0
jinseopkim0 force-pushed the feat-bigquery-arrow-it branch from 41b71e7 to 91e6ea9 Compare September 18, 2026 16:17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces integration tests to verify BigQuery queries using the Arrow results format, specifically testing single-page and multi-page results. The review feedback suggests strengthening the assertions in the single-page test by validating the schema and actual values within the VectorSchemaRoot, rather than only checking the row count.

Comment on lines +7517 to +7521
for (VectorSchemaRoot root : result) {
batchCount++;
totalRows += root.getRowCount();
assertEquals(1, root.getRowCount());
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure the integrity of the data returned via the Arrow format, consider validating the schema and the actual values within the VectorSchemaRoot. Currently, the test only validates the row count, which could pass even if the data itself is corrupted or incorrectly mapped.

      for (VectorSchemaRoot root : result) {
        batchCount++;
        totalRows += root.getRowCount();
        assertEquals(1, root.getRowCount());
        assertNotNull(root.getSchema().findField("id"));
        assertNotNull(root.getSchema().findField("name"));
        assertNotNull(root.getSchema().findField("ts"));
        assertEquals(1L, root.getVector("id").getObject(0));
        assertEquals("hello", root.getVector("name").getObject(0).toString());
      }

@jinseopkim0
jinseopkim0 merged commit 4505e95 into main Sep 18, 2026
209 of 210 checks passed
@jinseopkim0
jinseopkim0 deleted the feat-bigquery-arrow-it branch September 18, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants