Skip to content

perf(spanner): make internal AsyncResultSet row production non-blocking #14268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
olavloite wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf(spanner): make internal AsyncResultSet row production non-blocking #14268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...nner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,6 +1301,7 @@ CloseableIterator<PartialResultSet> startStream(
request.getLastStatement(),
prefetchChunks,
cancelQueryWhenClientIsClosed);
setStream(stream);
if (streamListener != null) {
stream.registerListener(streamListener);
}
Expand Down Expand Up @@ -1536,6 +1537,7 @@ CloseableIterator<PartialResultSet> startStream(
GrpcStreamIterator stream =
new GrpcStreamIterator(
lastStatement, prefetchChunks, cancelQueryWhenClientIsClosed);
setStream(stream);
if (streamListener != null) {
stream.registerListener(streamListener);
}
Expand Down
8 changes: 8 additions & 0 deletions ...panner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,14 @@ default boolean initiateStreaming(AsyncResultSet.StreamMessageListener streamMes

/** it requests the initial prefetch chunks from gRPC stream */
default void requestPrefetchChunks() {}

/**
* Returns true if data (a chunk, row, EOF, or error) is available to read immediately without
* blocking the calling thread on network I/O.
*/
default boolean isDataAvailable() {
return true;
}
}

static double valueProtoToFloat64(com.google.protobuf.Value proto) {
Expand Down
Loading
Loading