test(showcase): add IT against showcase for ResumableUploadCallable - #14244
Draft
whowes wants to merge 1 commit into
Draft
test(showcase): add IT against showcase for ResumableUploadCallable#14244whowes wants to merge 1 commit into
whowes wants to merge 1 commit into
Conversation
whowes
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new integration test class, ITResumableUploadCallable, to verify the resumable upload pipeline against Showcase under various scenarios, including single-chunk, multi-chunk, zero-byte uploads, timeouts, and cancellations. The review feedback recommends awaiting the termination of the ScheduledExecutorService during teardown to prevent potential thread leaks.
Comment on lines
+174
to
+176
| if (executor != null) { | ||
| executor.shutdownNow(); | ||
| } |
Contributor
There was a problem hiding this comment.
The ScheduledExecutorService is shut down using shutdownNow(), but its termination is not awaited. To prevent thread leaks and ensure resources are fully released before subsequent tests run, please await the executor's termination. Additionally, ensure that teardown or close methods perform explicit null checks before invoking methods on lazily initialized resources to prevent NullPointerException.
if (executor != null) {
executor.shutdownNow();
executor.awaitTermination(TestClientInitializer.AWAIT_TERMINATION_SECONDS, TimeUnit.SECONDS);
}References
- When using lazily initialized resources (such as ExecutorService), ensure that teardown or close methods perform explicit null checks before invoking methods on them to prevent NullPointerException.
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
from
September 2, 2026 17:11
04bf956 to
3eb43da
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
from
September 2, 2026 17:12
3eb43da to
7476681
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
2 times, most recently
from
September 2, 2026 19:01
018d72d to
6362e8a
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
2 times, most recently
from
September 2, 2026 20:00
4af6505 to
0566d84
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
2 times, most recently
from
September 2, 2026 22:32
26f77ac to
3d62765
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
from
September 3, 2026 05:29
3d62765 to
7e0b084
Compare
whowes
changed the base branch from
whowes/resumable-upload-factory
to
whowes/resumable-upload-settings
September 3, 2026 05:36
|
|
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
2 times, most recently
from
September 4, 2026 02:44
27e12bd to
4ef352a
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
2 times, most recently
from
September 4, 2026 19:46
b93f790 to
782059e
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
from
September 4, 2026 21:44
782059e to
6b2a0cc
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
from
September 4, 2026 21:44
6b2a0cc to
cf6cd11
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
from
September 4, 2026 21:54
cf6cd11 to
2711ec2
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
2 times, most recently
from
September 4, 2026 22:35
4874a77 to
490e7a2
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
from
September 4, 2026 23:35
490e7a2 to
215302d
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
2 times, most recently
from
September 4, 2026 23:52
231b074 to
7e6eec1
Compare
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
from
September 5, 2026 00:51
7e6eec1 to
aff0da6
Compare
Add integration tests against local GAPIC Showcase server for ResumableUploadCallable, validating: 1. Single-chunk upload happy path. 2. Multi-chunk upload with multiple intermediate chunks and final chunk. 3. 0-byte upload and exact-chunk uploads with separate 0-byte finalize request. 4. Future cancellation and timeout handling. 5. Convenience futureCall(request, stream) overload. 6. Per-request ApiCallContext extra header overrides. 7. Stub-level and per-request ResumableUploadCallSettings overrides. 8. Stub-level and per-request global timeout watchdog triggering DeadlineExceededException.
whowes
force-pushed
the
whowes/resumable-upload-happy-path-it
branch
from
September 5, 2026 00:57
aff0da6 to
e05f31d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For illustration only - this PR will not be merged. This is basically a unit test for the Callable except against the showcase fake rather than mocks. The proper IT for resumable uploads will operate on the client library level rather than the Callable.