Skip to content

feat(gax-java): add JSpecify Null annotations to gax#13799

Draft
nnicolee wants to merge 3 commits into
mainfrom
feat/jspecify-gax-auth
Draft

feat(gax-java): add JSpecify Null annotations to gax#13799
nnicolee wants to merge 3 commits into
mainfrom
feat/jspecify-gax-auth

Conversation

@nnicolee

Copy link
Copy Markdown
Contributor

tba

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces JSpecify nullness annotations, specifically adding @NullMarked and @Nullable across numerous classes in the gax, gax-grpc, and gax-httpjson modules to enhance null-safety. One issue was identified regarding an accidentally committed temporary compiler arguments file (javac.20260715_171737.args), which should be removed and added to .gitignore.

@@ -0,0 +1 @@
@/tmp/org.codehaus.plexus.compiler.javac.JavacCompiler7653064300311673901arguments

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This file appears to be a temporary compiler arguments file generated during the build process. It should not be committed to the repository. Please remove this file and add it to the .gitignore file to prevent it from being tracked in the future.

@nnicolee
nnicolee requested a review from lqiu96 July 17, 2026 05:12
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
C Reliability Rating on New Code (required ≥ A)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant