feat(bigquery-jdbc): implement PreparedStatement ParameterMetaData and Calendar date setters#13794
Open
Neenu1995 wants to merge 4 commits into
Open
feat(bigquery-jdbc): implement PreparedStatement ParameterMetaData and Calendar date setters#13794Neenu1995 wants to merge 4 commits into
Neenu1995 wants to merge 4 commits into
Conversation
…d Calendar date setters
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the BigQuery JDBC driver by implementing missing parameter setter methods in BigQueryPreparedStatement, adding BigQueryParameterMetaData support, and updating type mappings to include SMALLINT, TINYINT, and NULL types. The reviewer correctly identified that the setDate, setTime, and setTimestamp methods with Calendar overloads modify the provided Calendar object in-place, which is an unexpected side effect for callers. It is recommended to clone the Calendar object before performing modifications to ensure the original object remains unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/535194644
BigQueryPreparedStatement.getParameterMetaData()for client-side schema discovery (getParameterCount,getParameterType,getParameterTypeName,getParameterClassName).setDate(index, date, cal),setTime(index, time, cal), andsetTimestamp(index, timestamp, cal)using field-projection math for accurate target timezone handling.java.timeSupport: IntegratedLocalDate,LocalTime,LocalDateTime,OffsetDateTime,Instant, andZonedDateTimeintosetObject()overloads.java.timeclasses inBigQueryJdbcTypeMappings.classToTypeto map toStandardSQLTypeName.DATE,TIME, andTIMESTAMP.