feat(bigquery-jdbc): implement parameter setters in PreparedStatement#13792
Open
Neenu1995 wants to merge 3 commits into
Open
feat(bigquery-jdbc): implement parameter setters in PreparedStatement#13792Neenu1995 wants to merge 3 commits into
Neenu1995 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements several previously unsupported JDBC setter methods in BigQueryPreparedStatement, including setNull, setShort, setBytes, setObject, and setArray, along with corresponding type mappings in BigQueryJdbcTypeMappings and comprehensive unit and integration tests. The review feedback highlights opportunities to improve type consistency by mapping Types.SMALLINT and Types.TINYINT to Short.class and Byte.class respectively, propagating SQLException in setNull instead of silently swallowing it, and simplifying setShort to use Short.class directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/535194644
BigQueryPreparedStatement.java):setShort,setByte,setInt,setLong,setFloat,setDouble,setBigDecimal,setBoolean,setString,setBytes,setObject, andsetNull.BigQueryParameterHandlerwith correct Java type metadata.BigQueryParameterHandler.java):configureParameters(...)when constructingQueryParameterValue:Short,Byte, andBigIntegerLongforStandardSQLTypeName.INT64.FloatDoubleforStandardSQLTypeName.FLOAT64.IllegalArgumentException: Type INT64 incompatible with java.lang.Shortduring query execution.BigQueryJdbcTypeMappings.java):Types.SMALLINTjava.lang.Short,Types.TINYINTjava.lang.Byte).ParameterMetaData.getParameterClassName()remains 100% compliant with JDBC standards.