Skip to content

[DO not submit] [testing] takeover issues test in CI #13780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dhriti07 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DO not submit] [testing] takeover issues test in CI #13780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e/google-cloud-storage/src/test/java/com/google/cloud/storage/ITAppendableUploadTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@

@RunWith(StorageITRunner.class)
@CrossRun(
backends = {Backend.TEST_BENCH},
backends = {Backend.TEST_BENCH, Backend.PROD},
transports = Transport.GRPC)
@Parameterized(UploadConfigParameters.class)
public final class ITAppendableUploadTest {
Expand Down
4 changes: 2 additions & 2 deletions ...d-storage/src/test/java/com/google/cloud/storage/it/runner/registry/BackendResources.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,10 +259,10 @@ static BackendResources of(
protectedBucketNames.add(bucketName);
return new BucketInfoShim(
BucketInfo.newBuilder(bucketName)
.setLocation(zone.get().get().getRegion())
.setLocation("us-central1")
.setCustomPlacementConfig(
CustomPlacementConfig.newBuilder()
.setDataLocations(ImmutableList.of(zone.get().get().getZone()))
.setDataLocations(ImmutableList.of("us-central1-c"))
Comment on lines +262 to +265

@gemini-code-assist gemini-code-assist Bot Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding the region (us-central1) and zone (us-central1-c) limits the portability of the integration tests. It is highly recommended to dynamically resolve these values using the configured zone/region from the runner context to ensure tests can run seamlessly across different environments or projects.

Suggested change
.setLocation("us-central1")
.setCustomPlacementConfig(
CustomPlacementConfig.newBuilder()
.setDataLocations(ImmutableList.of(zone.get().get().getZone()))
.setDataLocations(ImmutableList.of("us-central1-c"))
.setLocation(zone.get().get().getRegion())
.setCustomPlacementConfig(
CustomPlacementConfig.newBuilder()
.setDataLocations(ImmutableList.of(zone.get().get().getZone()))

.build())
.setStorageClass(StorageClass.valueOf("RAPID"))
.setHierarchicalNamespace(
Expand Down
Loading