Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the managed-workload.sh CI script to configure network and subnet settings for Cloud Run jobs. It introduces NETWORK and SUBNET environment variables, defaulting to IPv6 DirectPath values, and applies them along with --vpc-egress=all-traffic to the gcloud alpha run jobs create command. There are no review comments, and I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16518 +/- ##
==========================================
- Coverage 92.37% 92.36% -0.01%
==========================================
Files 2262 2262
Lines 217100 217100
==========================================
- Hits 200540 200520 -20
- Misses 16560 16580 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
colinmoy
approved these changes
Oct 1, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.