perf(v7): lock-free atomic compare-and-swap monotonicity for NewV7 - #230
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the global
timeMumutex ingetV7Time()with an atomic Compare-And-Swap (atomic.CompareAndSwapInt64) state loop.Motivation
Previously, every call to
NewV7()acquired a global mutextimeMu.Lock()to serialize timestamp increments and sub-millisecond sequence numbers. Under multi-goroutine concurrent workloads, this causes severe lock contention and thread synchronization overhead, contending with UUIDv1 operations that also sharetimeMu.Solution
(milli << 12) + seq) inlastV7timeusing lock-free atomic CAS.next <= last), advancenext = last + 1atomically.TestVersion7ConcurrentMonotonicitywith 16 concurrent goroutines producing 80,000 UUIDs to verify strict monotonicity under concurrent contention.Fixes #226