Add local_rank configuration support to ExporterOptions to allow worker rank identification in distributed multi-host/multi-rank environments. - #770
Open
copybara-service[bot] wants to merge 1 commit into
Conversation
…worker rank identification in distributed multi-host/multi-rank environments. Key improvements: - Add `local_rank` field (`std::optional<std::string>`) to `ExporterOptions` in `metrics_backend.h`. - Update `InitializeFromEnvironment` and `InitializeFromBackendNames` in `metrics_api` to accept `ExporterOptions` and resolve `local_rank` (falling back to the `LOCAL_RANK` environment variable when unset or empty). - Extend Python binding `configure_telemetry` in `telemetry_binding.cc` with optional `local_rank` parameter (supporting strings and integers). - Add unit tests in C++ (`metrics_api_test.cc`) and Python (`telemetry_binding_test.py`) covering explicit rank passing, `LOCAL_RANK` environment fallback, empty rank strings, and invalid type handling. PiperOrigin-RevId: 969642718
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
local_rankconfiguration support toExporterOptionsto allow worker rank identification in distributed multi-host/multi-rank environments.Key improvements:
local_rankfield (std::optional<std::string>) toExporterOptionsinmetrics_backend.h.InitializeFromEnvironmentandInitializeFromBackendNamesinmetrics_apito acceptExporterOptionsand resolvelocal_rank(falling back to theLOCAL_RANKenvironment variable when unset or empty).configure_telemetryintelemetry_binding.ccwith optionallocal_rankparameter (supporting strings and integers).metrics_api_test.cc) and Python (telemetry_binding_test.py) covering explicit rank passing,LOCAL_RANKenvironment fallback, empty rank strings, and invalid type handling.