fix: Enable submitting empty allowlist for actions permissions patterns#4371
Open
deiga wants to merge 3 commits into
Open
fix: Enable submitting empty allowlist for actions permissions patterns#4371deiga wants to merge 3 commits into
deiga wants to merge 3 commits into
Conversation
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
deiga
changed the title
gmlewis
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4371 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 193 193
Lines 19526 19526
=======================================
Hits 19040 19040
Misses 269 269
Partials 217 217 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Jul 7, 2026
alexandear
reviewed
Jul 8, 2026
| GithubOwnedAllowed *bool `json:"github_owned_allowed,omitempty"` | ||
| VerifiedAllowed *bool `json:"verified_allowed,omitempty"` | ||
| PatternsAllowed []string `json:"patterns_allowed,omitempty"` | ||
| PatternsAllowed []string `json:"patterns_allowed,omitzero"` |
Contributor
There was a problem hiding this comment.
Let's add a comment about distinguishing passing an empty slice []string{} and passing nil slice and why we need both.
Contributor
Author
There was a problem hiding this comment.
@alexandear Done. I hope it's placed correctly 😬
alexandear
approved these changes
Jul 8, 2026
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
gmlewis
requested changes
Jul 8, 2026
| GithubOwnedAllowed *bool `json:"github_owned_allowed,omitempty"` | ||
| VerifiedAllowed *bool `json:"verified_allowed,omitempty"` | ||
| PatternsAllowed []string `json:"patterns_allowed,omitempty"` | ||
| PatternsAllowed []string `json:"patterns_allowed,omitzero"` // omitzero is used to allow empty array to be sent in the request body, to configure the organization to allow no 3rd-party actions. It needs to still omit a `nil` value, so that it's possible to patch the other values without changing the allowed actions. |
Collaborator
There was a problem hiding this comment.
Suggested change
| PatternsAllowed []string `json:"patterns_allowed,omitzero"` // omitzero is used to allow empty array to be sent in the request body, to configure the organization to allow no 3rd-party actions. It needs to still omit a `nil` value, so that it's possible to patch the other values without changing the allowed actions. | |
| // PatternsAllowed uses `omitzero` allow an empty array to be sent in the request body in order to | |
| // configure the organization to allow no 3rd-party actions. It needs to still omit a `nil` value so | |
| // that it's possible to patch the other values without changing the allowed actions. | |
| PatternsAllowed []string `json:"patterns_allowed,omitzero"` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4359
This PR changes
PatternsAllowedto useomitzeroinstead ofomitempty. That enables submitting an empty List to the API and thus override any currently set allowlisted patterns.